8000 Fixes #254, #262, #267, #269 by robthew · Pull Request #293 · mitre/heimdall-lite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixes #254, #262, #267, #269 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 4, 2020
Merged

Fixes #254, #262, #267, #269 #293

merged 23 commits into from
Aug 4, 2020

Conversation

robthew
Copy link
Contributor
@robthew robthew commented Jul 29, 2020 •
edited by Bialogs
Loading

  • Unified Errors

  • Better timeouts

  • Error spacing Issue

  • Errors dismiss after changing tabs within the upload nexus

  • Rebase against master

  • Fix sign off issue

@robthew robthew requested a review from Bialogs July 29, 2020 18:29
@aaronlippold aaronlippold added bug Something isn't working enhancement New feature or request labels Jul 29, 2020
This was linked to issues Jul 29, 2020
Errors are continually added when attempting to log in #254
Closed
Errors are not dismissed automatically #267
Closed
Spacing issue on error popup options #269
Closed
Bialogs
Bialogs suggested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor
@Bialogs Bialogs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the timeout for the vuetify error (3s) is a bit short to read the full error you get when you upload something and receive an error. Maybe something in the 8-10s range would be appropriate for those longer error messages. The width looks much better now though.
As for the errors on the UploadNexus...Errors are not cleared when navigating between the specific page in the upload nexus you are on which was part of #254. What I mean by that is if I encounter an error when logging in to S3 but then I click on the Splunk tab the errors should be removed.

rbclark
rbclark reviewed Jul 29, 2020
View reviewed changes
@robthew robthew linked an issue Jul 30, 2020 that may be closed by this pull request
No unified error look and feel #268
Closed
@Bialogs
Copy link
Contributor
Bialogs commented Jul 30, 2020

I placed a checklist in the PR description to track what I'd like to see done before this is merged. I think it looks good except for the one left blank.

@robthew
Copy link
Contributor Author
robthew commented Jul 30, 2020

The ErrorTooltip has been replaced with the Toast error popups which dismiss automatically. This should take care of the changing tabs issue.

What is the sign off issue that needs fixing?

@Bialogs
Copy link
Contributor
Bialogs commented Jul 30, 2020

What is the sign off issue that needs fixing?

The contributor agreement as part of the automatic checks. You can see that under the automated checks section of the PR.

@Bialogs
Copy link
Contributor
Bialogs commented Jul 30, 2020 •
edited
Loading

Also seeing the following issue on this build of heimdall-lite which is not present on netlify...Please note the search bar text as well as the fact I can access this part of the application with an invalid & malformed login.

Looks like something changed and the error isn't blocking the next action from occurring.

output

robthew and others added 11 commits July 31, 2020 13:13
@robthew
Added user menu
696b1d2 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Put user menu in component
86e8d03 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unify prettierrc with the one in heimdall2
58f1627 
This provides us with a consistent style and spacing across the two projects in preparation to merge them into 1 repo

Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Remove link tags to externally hosted icons and fonts.(#288)
ed5535f 
* downloaded material icons

* removed external references

Signed-off-by: Robert Thew <rthew@mitre.org>
@cjdoherty @Mitriol @robthew
Cci tooltips final (#286)
fd2a309 
* added cci tag dictionary
* added test counts to status cards
* added cci data
* added cci descriptions to tag tooltip
* Fixed NIST lookups to tolerate alternate formats
* rearanged control table row
* added links on tags to nist.gov page
* changed 'tags' to '800-53 Controls & CCIs'
* optimized status count

Signed-off-by: Colin Doherty <oneofthree103@gmail.com>
Signed-off-by: Jacob Henry <jchenry@mitre.org>
Co-authored-by: Jacob Henry <jchenry@mitre.org>
Co-authored-by: Mitriol <51966679+Mitriol@users.noreply.github.com>
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Swaped chevron to make direction more clear
1135533 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Fixes #254, #262, #267, #269
308761a 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unifies error messaging
a6625d8 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unifies error messaging
798156c 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Fixes #254, #262, #267, #269
503b40c 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unifies error messaging
968843e 
Signed-off-by: Robert Thew <rthew@mitre.org>
robthew added 4 commits August 3, 2020 12:53
@robthew
Fixed error step in Splunk login
7db50a1 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Put user menu in component
0d16920 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Fixes #254, #262, #267, #269
510020c 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unifies error messaging
f1621b2 
Signed-off-by: Robert Thew <rthew@mitre.org>
robthew added 5 commits August 3, 2020 14:58
@robthew
Unifies error messaging
7d339c2 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Fixes #254, #262, #267, #269
431c19b 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Unifies error messaging
7adf82c 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Fixed error step in Splunk login
c8c45fc 
Signed-off-by: Robert Thew <rthew@mitre.org>
@robthew
Merge branch 'ui_issues' of https://github.com/mitre/heimdall-lite in…
bc78642 
…to ui_issues
rbclark
rbclark reviewed Aug 3, 2020
View reviewed changes
@Bialogs Bialogs self-requested a review August 4, 2020 13:20
Bialogs
Bialogs suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor
@Bialogs Bialogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors are still sticking around when navigating between tabs in the upload nexus and you can still bypass the changes you made to the Splunk login by hitting the login button twice in a row.

@robthew
removed dead style
c331c36 
Signed-off-by: Robert Thew <rthew@mitre.org>
@Bialogs
Copy link
Contributor
Bialogs commented Aug 4, 2020

I think the best way to fix the login to Splunk issue is to perform additional validation on the hostname the user is trying to connect to.

@robthew
removes error on tab switch
4ff7e78 
Signed-off-by: Robert Thew <rthew@mitre.org>
@Bialogs Bialogs self-requested a review August 4, 2020 20:38
Bialogs
Bialogs previously approved these changes Aug 4, 2020
View reviewed changes
@Bialogs Bialogs merged commit a2db66c into master Aug 4, 2020
@Bialogs Bialogs deleted the ui_issues branch August 4, 2020 20:58
rbclark pushed a commit to mitre/heimdall2 that referenced this pull request Aug 26, 2020
@robthew
Fixes mitre/heimdall-lite#254, mitre/heimdall-lite#262, mitre/heimdal…
e9e2def 
…l-lite#267, mitre/heimdall-lite#269 (mitre/heimdall-lite#293)

Fixes several issues with error population and dismissal including a unified error look and feel.
Sign up for free to join this conversation on GitHub< 67E6 /strong>. Already have an account? Sign in to comment
Reviewers

@rbclark rbclark rbclark left review comments

@Bialogs Bialogs Bialogs approved these changes

Assignees

@robthew robthew

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@robthew @Bialogs @rbclark @aaronlippold @cjdoherty
0