Closed
Description
I want to eventually contribute to this Keras issue, and since this would be my first contribution, I want to start small and implement arctan2. If nobody is currently working on this, I would like to contribute this feature. Specifically, my implementation plan, based on looking at arctan, is as follows:
- Add an
ArcTan2class tomlx/primitives.h, and its correspondingvjp,jvp, andvmapfunctions inmlx/primitives.cpp - Add an
ArcTan2struct tomlx/backend/common/ops.h, and overload the function call operator. - Add an
ArcTan2struct tomlx/backend/metal/unary.h, and addinstantitate_unary_floatcalls inmlx/backend/metal/unary.metal. The necessarymetal::precise::atan2function seems to already be implemented. - Add tests, and update docs.
Please let me know if I can proceed.