Bump to MLX v0.15.2 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeloskath
approved these changes
Jul 8, 2024
mlx/c/distributed_group.cpp
Outdated
| RETURN_MLX_C_DISTRIBUTED_GROUP(mlx::core::distributed::init(strict)); | ||
| } | ||
|
|
||
| extern "C" mlx_stream mlx_distributed_communication_stream() { |
There was a problem hiding this comment.
I am not so sure we want to expose that. 🤔 Nobody is using it but the communication ops. Ideally we wouldn't want people to submit other ops in the communication stream.
There was a problem hiding this comment.
Don't cross the streams.
There was a problem hiding this comment.
I was actually unsure about exposing this one, so I will remove it
davidkoski
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.