8000 Fix scaled dot product attention mask argument by louen · Pull Request #236 · ml-explore/mlx-swift · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix scaled dot product attention mask argument #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

Fix scaled dot product attention mask argument #236

merged 2 commits into from
May 7, 2025

Conversation

louen
Copy link
Contributor
@louen louen commented May 7, 2025 •
edited
Loading

It looks like the value passed in the mask_mode should be the empty string by default.

@louen louen changed the title Fix scaled dot product attention reversed condition Fix scaled dot product attention mask argument May 7, 2025
@louen louen marked this pull request as ready for review May 7, 2025 23:09
davidkoski
davidkoski approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator
@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice find!

@davidkoski davidkoski merged commit a8f7411 into ml-explore:main May 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkoski davidkoski davidkoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louen @davidkoski
0