8000 Added BCE with Logits Loss for classification by sarthakpati · Pull Request #395 · mlcommons/GaNDLF · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added BCE with Logits Loss for classification #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Added BCE with Logits Loss for classification #395

wants to merge 4 commits into from

Conversation

sarthakpati
Copy link
Collaborator

Fixes #N.A.

Proposed Changes

  • added a new loss for classification

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@dagshub
Copy link
dagshub bot commented Apr 8, 2022

Join the discussion on DagsHub!

@sarthakpati sarthakpati requested a review from orhunguley April 8, 2022 01:50
@codecov
Copy link
codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #395 (74d24ed) into master (deec189) will increase coverage by 0.02%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   91.77%   91.79%   +0.02%     
==========================================
  Files         100      100              
  Lines        5723     5754      +31     
==========================================
+ Hits         5252     5282      +30     
- Misses        471      472       +1
Flag Coverage Δ
unittests 91.79% <96.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/losses/regression.py 91.91% <91.66%> (-0.13%) ⬇️
GANDLF/losses/__init__.py 100.00% <100.00%> (ø)
testing/test_full.py 98.26% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deec189...74d24ed. Read the comment docs.

@sarthakpati
Copy link
Collaborator Author

Keeping this as draft until @orhunguley gets time to fix the logic for this, since this should only be used for binary task classification problem.

@sarthakpati sarthakpati marked this pull request as draft April 8, 2022 13:48
@sarthakpati
Copy link
Collaborator Author

Closing till @orhunguley gets a chance to work on this. 🚀

@sarthakpati sarthakpati deleted the bce_logits_loss branch February 22, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geeks-Sid Geeks-Sid Geeks-Sid approved these changes

@orhunguley orhunguley Awaiting requested review from orhunguley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakpati @Geeks-Sid
0