8000 Issue Fix: self keyword missing in rules.py by garimajain05 · Pull Request #104 · mlcommons/storage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Issue Fix: self keyword missing in rules.py #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Issue Fix: self keyword missing in rules.py #104

wants to merge 1 commit into from

Conversation

garimajain05
Copy link

This PR addresses Issue #103

There is a bug in the checkpointing feature that is causing an error—I couldn't run checkpointing and received the error message "Error occurred during benchmark verification: name 'benchmark' is not defined. Contact the developer."

One of the reasons was that in rules.py line 138, self. was missing in front of benchmark.args.closed

It should be:
elif not self.benchmark.args.closed:

@garimajain05 garimajain05 requested a review from a team as a code owner May 22, 2025 14:37
@github-actions GitHub Actions
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
❌ @root
root seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@johnugeorge
Copy link
Contributor

@garimajain05 Can you rebase?

@johnugeorge
Copy link
Contributor

Can you sign cla-bot?

@wvaske
Copy link
Contributor
wvaske commented May 22, 2025

@garimajain05 , if signing the CLA will take a while, let me know and I'll add this to one of my PRs.

@garimajain05
Copy link
Author

@garimajain05 , if signing the CLA will take a while, let me know and I'll add this to one of my PRs.
I have subscribed through the forms, however I haven't received an email yet

@garimajain05
Copy link
Author
garimajain05 commented May 22, 2025 via email

@johnugeorge
Copy link
Contributor

@garimajain05 Can you please complete it soon and make PR read ? Else, one of us can take it forward in the interest of time.

@garimajain05
Copy link
Author

Can you please complete it soon and make PR read ? Else, one of us can take it forward in the interest of time.

While rebasing, I noticed that the part of the code I was modifying no longer exists due to new changes committed to the codebase about an hour ago.
I'll go ahead and close this PR now. Thank you for your feedback and support!

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnugeorge johnugeorge johnugeorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garimajain05 @johnugeorge @wvaske
0