MosaicObj: major rewrite #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created the main program for make_mosaic with rough outline
- began outlining my ctypes wrapper for get_contact and created shared library to test function access
- created a draft of MosaicStruct and will make a proper unit test
- xarray vs netcdf4 package: unsure which is more suitable for mosaic file creation, may benefit mor
e from low-level interface, memory management, ... I can switch to xarray if needed and for uniformity.
i#
-Removed contact library -fixed typo in make_mosaic.py MosaicObj -Switched from netcdf4 to xarray package -used post_init to populate gridfiles and ntiles -> read_mosaic method & created file pointer for future use -implemented class method for generating grid dictionary -> need to work on making nested dict accessible
- use gridtools_utils for file checks - use dataarray.sizes to get dimension names to lengths - use gridtile names from mosaic file for griddict()
…tools into feature/MosaicObj
- reverted code in griddict to original for easier use in make_solo_mosaic - if/else clauses under write_out_mosaic to point data to None if not provided
…tools into feature/MosaicObj
…names from mosaic file when gridtiles are not given * Additional class method for creating regional mosaic file for make_regional_mosaic -- calls for less variables
- using setattr to retrieve data variables - rewrite write method to account for differing mosaic outputs - griddict -> get_grid which uses Mikyungs updated version of gridobj
…tools into feature/MosaicObj
mlee03
reviewed
May 16, 2025
mlee03
requested changes
May 16, 2025
mlee03
approved these changes
May 16, 2025
fmalatino
approved these changes
May 16, 2025
rem1776
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to mosaicobj -- includes some changes implemented by @mlee03 :