support formatting numbers with padding #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master-hax
commented
Jun 5, 2025
Comment on lines
+491
to
+495
| pub const fn $padded_function_name<const LENGTH: usize>(num: $type_name, padding: u8) -> AsciiNumber<LENGTH> { | ||
| const { assert!(LENGTH >= $needed_buffer_size) } | ||
| let mut string = [padding; LENGTH]; | ||
| let _ = $core_function_name(num, $base, &mut string); | ||
| return AsciiNumber { string, start: 0 } |
There was a problem hiding this comment.
this new (set of) function(s) contain(s) a static assertion that the specified length with padding is always at least the length of the s 7DE1 tring being generated - the code won't compile otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
feature request: #15
this PR will allow for automatically padding numbers initialized using the streamlined API. works at compile-time. (not sure the best way to implement this in the normal API)
change
add a new set of functions in the streamlined API
u8_padded,u16_padded, etc. that allow for initializing ascii numbers with padding to a user-defined but constant length, that is statically verified to be at least the size of of the number itself.base16::i32_padded::<1>(256123, b'0')fails to compile, butbase16::i32_padded::<9>(256123, b'0')works fine.also add some tests
example usage