8000 value class check - catch KotlinReflectionInternalError by aSemy · Pull Request #922 · mockk/mockk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

value class check - catch KotlinReflectionInternalError #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2022
Merged

value class check - catch KotlinReflectionInternalError #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba52df1
value class check - catch KotlinReflectionInternalError
aSemy Sep 16, 2022
8244129
test isValue_safe doesn't throw KotlinReflectionInternalError
aSemy Sep 16, 2022
8bacef4
add assertion to test
aSemy Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modules/mockk-core/src/jvmMain/kotlin/io/mockk/core/ValueClassSupport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import kotlin.reflect.full.declaredMemberProperties
import kotlin.reflect.full.primaryConstructor
import kotlin.reflect.jvm.isAccessible
import kotlin.reflect.jvm.javaField
import kotlin.reflect.jvm.internal.KotlinReflectionInternalError


actual object ValueClassSupport {
Expand Down Expand Up @@ -61,6 +62,8 @@ actual object ValueClassSupport {
private val <T : Any> KClass<T>.isValue_safe: Boolean
get() = try {
this.isValue
} catch (_: KotlinReflectionInternalError) {
false
} catch (_: UnsupportedOperationException) {
false
}
Expand Down
4 changes: 3 additions & 1 deletion test-modules/client-tests/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ plugins {
}

kotlin {
jvm()
jvm {
withJava()
}

sourceSets {
val commonMain by getting {
Expand Down
10 changes: 10 additions & 0 deletions test-modules/client-tests/src/jvmTest/java/io/mockk/core/JavaEnum.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package io.mockk.core;

/** @see ValueClassSupport */
public enum JavaEnum {
A {
public String toString() {
return "aaa";
}
}
}
27 changes: 27 additions & 0 deletions test-modules/client-tests/src/jvmTest/kotlin/io/mockk/core/ValueClassSupportTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package io.mockk.core

import io.mockk.every
import io.mockk.mockk
import kotlin.test.Test
import kotlin.test.assertEquals


class ValueClassSupportTest {

/** https://github.com/mockk/mockk/issues/868 */
@Test
fun `verify Java class does not cause KotlinReflectionInternalError`() {
val mock = mockk<MockTarget> {
every { func() } returns JavaEnum.A
}

val result = mock.func() // check this doesn't throw KotlinReflectionInternalError

assertEquals(JavaEnum.A, result)
}

}

private class MockTarget {
fun func(): JavaEnum = JavaEnum.A
}
0