feat: Add identifier property to ScreenElement #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmegidish can you please take a look? this change makes sense to me |
|
@tomoya0x00 This pull request looks great. I'll be merging this in, and I'll implement the iOS counterpart as well. There it's called accessibility hint. Thank you so much for this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the accessibilityIdentifier in iOS and the id that can be specified in Compose's testTag in Android to the ScreenElement as the identifier property.
This is useful when there are multiple UI elements with the same name, or to identify image UI elements that have no name.