Use prost for grpc generated types #4032

nick-mobilecoin · 2025-04-27T01:56:37Z

No description provided.

nick-mobilecoin · 2025-04-27T22:57:35Z

This will need some discussion as to whether or not it's worth the cost/benefit of doing

The reasons to consider moving over to prost for the gRPC generated types is:

Protobuf version 2 is an older version that isn't actively maintained for features:
a. There is a current vulnerability for version 2, https://rustsec.org/advisories/RUSTSEC-2024-0437.html
b. There is a protobuf version 3, but the repo currently says it's looking for a maintainer
prost works in a 'no_std'.
a. We currently have protobuf/prost types generated at compile time and some defined in the enclave using prost derives.
b. Using prost everywhere may allow us to generate the prost types for use in the enclave and re-use them in untrusted instead of defining types twice.
A desire to move form grpc-rs to Tonic.
a. Tonic works with rust's native async, while grpc-rs has it's own asynchronous behavior
b. Currently our slowest build step is grpc-rs
c. grpc-rs hasn't had a release in 18 months and hasn't seen a change in 8 months. It could just be a solid and stable project not needing any change.

eranrund · 2025-04-28T16:00:13Z

This will need some discussion as to whether or not it's worth the cost/benefit of doing

The reasons to consider moving over to prost for the gRPC generated types is:

1. Protobuf version 2 is an older version that isn't actively maintained for features:
   a. There is a current vulnerability for version 2, https://rustsec.org/advisories/RUSTSEC-2024-0437.html
   b. There is a protobuf version 3, but the repo currently says it's looking for a maintainer

2. prost works in a 'no_std'.
   a. We currently have protobuf/prost types generated at compile time and some defined in the enclave using prost derives.
   b. Using prost everywhere may allow us to generate the prost types for use in the enclave and re-use them in untrusted instead of defining types twice.

3. A desire to move form grpc-rs to Tonic.
   a. Tonic works with rust's native async, while grpc-rs has it's own asynchronous behavior
   b. Currently our slowest build step is grpc-rs
   c. grpc-rs hasn't had a release in 18 months and hasn't seen a change in 8 months. It could just be a solid and stable project not needing any change.

Thanks!
These are all good reasons!

nick-mobilecoin · 2025-05-06T01:00:42Z

CD run done here, https://github.com/mobilecoinfoundation/mobilecoin/actions/runs/14848610519/job/41689430951

admin-http-gateway/src/main.rs

api/proto/external.proto

api/proto/printable.proto

api/src/convert/account_key.rs

api/src/convert/amount.rs

api/src/convert/archive_block.rs

api/src/convert/account_key.rs

api/src/convert/ring_mlsag.rs

eranrund

What a beast of a PR... thanks for toiling on that!
I think it's pretty close to being good to go - I had some minor nits (that can also be ignored) and more interestingly some questions around handling casting of enum values and the behavior around unknown variants.

admin-http-gateway/src/main.rs

api/src/convert/archive_block.rs

api/src/convert/collateral.rs

consensus/api/src/lib.rs

mobilecoind/api/src/lib.rs

mobilecoind/src/service.rs

peers/src/threaded_broadcaster.rs

t3/api/src/lib.rs

util/b58-decoder/src/bin/main.rs

Co-authored-by: Eran Rundstein <eran@rundste.in>

Use prost for grpc generated types

af724ed

eranrund mentioned this pull request Apr 27, 2025

Move everything to prost 11 #4031

Open

nick-mobilecoin marked this pull request as draft April 27, 2025 22:58

nick-mobilecoin added 3 commits May 2, 2025 19:49

Fix some tests

e3f080b

Fix mint client tests

0fee6ed

Get the mode as an enum

c62b33c