8000 Update rust to 2023-01-04 by samdealy · Pull Request #2986 · mobilecoinfoundation/mobilecoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update rust to 2023-01-04 #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update rust to 2023-01-04 #2986

wants to merge 3 commits into from

Conversation

samdealy
Copy link
Contributor
@samdealy samdealy commented Jan 5, 2023 •
edited
Loading

Motivation

The repo is currently using of the nightly-2022-04-29 version of rust. This is problematic because it prevents us from using some of the latest features (e.g. #2965). This PR updates Rust and fixes a few clippy errors such as:

  • Inline text for 8000 matting
  • Result error variant too large: note, we disabled this lint because we don't want to introduce an alloc and the change is pretty substantial (you have to Box a lot of errors and are therefore unable to destructure inner error fields because Box is an opaque type, thus decreasing readability)
  • Removal of unnecssary clone or references that clippy didn't catch previously.

If you see any instances of changes outside of those outlined above, feel free to leave a comment and I'll double check that it should be included.

Future Work

  • Update repos that use mobilecoin.git as a submodule.

This was referenced Jan 5, 2023
Merged
Merged
Merged
@samdealy
Copy link
Contributor Author
samdealy commented Jan 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@samdealy samdealy self-assigned this Jan 5, 2023
@samdealy samdealy force-pushed the sam/update-rust branch 3 times, most recently from 6c7ab8c to 6c25a9d Compare January 6, 2023 21:08
@cbeck88
Copy link
Contributor 8000
cbeck88 commented Jan 6, 2023

Can we do this change in master branch?

@samdealy samdealy force-pushed the sam/update-rust branch 11 times, most recently from 922015c to 5c08f0f Compare January 9, 2023 22:00
@samdealy samdealy force-pushed the sam/sharding-config branch from c17637b to 72e6e91 Compare January 9, 2023 22:06
@samdealy samdealy force-pushed the sam/sharding-config branch from 72e6e91 to df9d548 Compare January 9, 2023 22:17
@samdealy samdealy force-pushed the sam/update-rust branch 5 times, most recently from 93ae9d2 to 2203aa0 Compare January 10, 2023 18:13
@samdealy samdealy force-pushed the sam/sharding-config branch from df9d548 to 70baba1 Compare January 10, 2023 21:21
@samdealy samdealy force-pushed the sam/update-rust branch 2 times, most recently from 9de99ab to a852819 Compare January 10, 2023 21:46
@samdealy
Copy link
Contributor Author

Closing in favor of #2999.

@samdealy samdealy closed this Jan 10, 2023
@samdealy samdealy deleted the sam/update-rust branch March 15, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samdealy samdealy

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samdealy @cbeck88
0