8000 Implement Fog View Router by samdealy · Pull Request #3297 · mobilecoinfoundation/mobilecoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement Fog View Router #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 115 commits into from
Apr 24, 2023
Merged

Implement Fog View Router #3297

merged 115 commits into from
Apr 24, 2023

Conversation

samdealy
Copy link
Contributor

Motivation

This PR contains all of the feature work related to the Fog View Router. Each change has already been independently reviewed on the feature/fog-view-router, and the branch itself has been kept up-to-date with master.

samdealy and others added 30 commits September 28, 2022 10:43
@samdealy
Fix Fog View Connection Cargo.toml dependencies
c22781a
@samdealy
Implement create_multi_view_query_data API for Fog View Router (#2115)
262eea6 
* Implement create_multi_view_store_query_data API

* Address remoun's comments
@samdealy
Implement MultiViewStoreQuery API for Fog View (#2133)
d4a7a61 
* Create MultiViewStoreQuery API for Fog View Store

* Implement multi_view_store_query in Fog View Store

* Use mut_decryption_error
@samdealy
Implement enclave APIs that facilitate Fog View Router dynamic store …
ed6cd60 
…discovery (#2200)

* Add client_init and client_connect enclave methods

* Move multiview query construction to ake enclave

* Implement Remoun's suggestions

* Implement second round of remoun's suggestions
@samdealy
Remove duplicate wasi files
c801436
@samdealy
Re-add older wasi version
d6b4d59
@samdealy
Implement query / dynamic shard component discovery in Fog View Router (
cc7d8be 
#2189)

* Remove FogViewStoreUri

* Implement core Fog Router Service logic

* Refactor module structure and add tests

* Use where clauses

* Implement nick's suggestions

* Implement second round of nick's suggestions

* Implement lint suggestions

* Implement james's suggestions

* Fix naming error

* Fix whitespace
@samdealy
Split Fog View API into Client-facing and Store (Fog Router) APIs (#2265
84017c7 
)

* Add FogViewStoreUri

* Split Fog View API in two and implement

* Implement nick's suggestions
@samdealy
Create helper methods to obliviously collate shard responses (#2252)
7366bee 
* Create helper methods that obliviously collate shard responses

* Implement chris's suggestions

* Fix error string

* Fix lint

* Sort dependencies

* Run format

* fix newline
@samdealy
Collate shard response in constant time (obliviously) (#2250)
01104d2 
* Add backend decrypt method to ake enclave

* Add enclave methods for shard response collation

* Refactor response to always include view store uri

* Use shard responses to fill router response

* Implement Nick's suggestions and fix CI errors
@samdealy
Implement epoch sharding via trait (#2350)
e3039f7
@samdealy
Use sharding strategy to tell view what blocks to process (#2351)
290bb5b
@samdealy
Return minimum highest processed block to client (#2387)
3a33948
@samdealy
Add config option for sharding strategy (#2352) 10000
f8fb892
@samdealy
Add readiness API to ShardingStrategy (#2353)
a329df2 
* Add readiness API to ShardingStrategy

* Implement readiness check per ShardingStrategy

* Change MVQR error to accommodate different types

* Set not ready message

* Pull out query processing logic to separate method
@samdealy
Add report fetching logic to FVR (#2454)
7989e7e
@samdealy
Fix responder ID usage in FVR (#2446)
3ba7998
@samdealy
Create different types of View Servers for store and client-facing (#…
f4d0ff7 
…2447)
@samdealy
Messages for noise protocol exchanges with explicit nonces (#2461)
2149b65 
* attest::NonceMessage, EnclaveNonceMessage, add handling to attest-ake

* Rustfmt fixes
@samdealy
Minor DRY cleanups around sessions and auth messages (#2462)
71e4bcd 
* attest::NonceMessage, EnclaveNonceMessage, add handling to attest-ake

* Rustfmt fixes

* Minor DRY cleanups around sessions and auth messages
@samdealy
Update FVR client for integration test (#2448)
fa685ca
@samdealy
Create gRPC FogViewRouterAdminAPI (#2360)
c59c8a4
@samdealy
Create FogViewRouterAdminUri (#2361)
045270c
@samdealy
update cargo lock
856128e
@awygle @samdealy
Sealed messages for clients with backends (#2449)
789ffb8 
* Implement client message to sealed message API for backends

* Update Fog View enclave to build with new AKE enclave API

* Rust type aliases don't protect against passing the aliased type, use a new type instead

* Re-add comment ASCII art

* Additional plumbing of new SealedClientMessage type

* Move SealedClientMessage, finish implementing in fog view router

* Properly update the lockfiles

* Fix clippy lint

* Update lockfiles again after rebase

Co-authored-by: Andrew Wygle <andrew@mobilecoin.com>
@samdealy
Implement shard management API sans auth (#2354)
53ee79c 
* Implement shard management API

* Implement James's suggestions
@samdealy
Re-apply 2463. (#2547)
0d0a4a1
@samdealy
Re-apply PR #2473 (was accidentally removed) (#2548)
2c7845b 
* Reapply changes from #2473
@samdealy
Add inbound frontend connection support crypto-ake-enclave (#2549)
42a425a 
* Add frontends

* Fix traits on NonceSession
@samdealy
Make constants and comments slightly friendlier/more consistent (#2550)
f1eee8a 
* Re-apply 2463. (#2547)

* Fix traits on NonceSession

* Minor comment and constant consistency/friendliness changes

* Fix compile error.

* Fix deleted Eq from NonceSession.
@samdealy samdealy marked this pull request as ready for review March 29, 2023 19:19
@samdealy samdealy force-pushed the feature/fog-view-router branch from df926c8 to 039d4b4 Compare March 29, 2023 21:52
@samdealy
Copy link
Contributor Author

@jcape I spoke with @aweis89, and he suggested that he merge his PR that contains the deployment fixes after Fog Ledger Router is merged to master. I agreed that it would be ok if we think FLR will get merged soon (by early next week) rather than later (the week after). What do you think?

@jcape jcape requested a review from NotGyro April 4, 2023 17:24
awygle
awygle approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor
@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as I expected, having already reviewed most of this work on the feature branch.

@nick-mobilecoin nick-mobilecoin requested review from nick-mobilecoin and removed request for NotGyro April 17, 2023 17:19
nick-mobilecoin
nick-mobilecoin requested changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator
@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main things are the unneeded dependencies and the regression of bringing back tempdir

@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 20, 2023
Open
@joekottke joekottke merged commit f6b702f into master Apr 24, 2023
@joekottke joekottke deleted the feature/fog-view-router branch April 24, 2023 18:11
@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 25, 2023
Closed
14 tasks
@eranrund eranrund restored the feature/fog-view-router branch July 28, 2023 18:35
@jgreat jgreat deleted the feature/fog-view-router branch July 31, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awygle awygle awygle approved these changes

@nick-mobilecoin nick-mobilecoin nick-mobilecoin approved these changes

@jcape jcape Awaiting requested review from jcape

@cbeck88 cbeck88 Awaiting requested review from cbeck88

@aweis89 aweis89 Awaiting requested review from aweis89

Assignees

@samdealy samdealy

Labels
None yet
Projects
< 4949 span class="ml-1">Core PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samdealy @awygle @nick-mobilecoin @joekottke @aweis89
0