added date to version number in changelog #27704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
|
/cc @vieux |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added line to CHANGELOG.md so that RPMs can build properly. They have been failing because the hack script converts CHANGELOG.md to RPM changelog format and the version number line is missing a date:
https://github.com/docker/docker/blob/1.12.x/hack/make/build-rpm#L56
- How I did it
With my fingers.
- How to verify it
See that the version line in the CHANGELOG.md now correctly has the date in parenthesis after the version number so that the RPMs can build.
- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)
🐩
Signed-off-by: Andrew Hsu andrewhsu@docker.com