8000 Cherry-pick #29877 : Use GetAllByCap to get list of network plugins in docker info by mavenugo · Pull Request #29878 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cherry-pick #29877 : Use GetAllByCap to get list of network plugins in docker info #29878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2017
Merged

Cherry-pick #29877 : Use GetAllByCap to get list of network plugins in docker info #29878

merged 1 commit into from
Jan 4, 2017

Conversation

mavenugo
Copy link
Contributor
@mavenugo mavenugo commented Jan 4, 2017 •
edited
Loading

Cherry picking #29877 to 1.13 branch as well.

returned in "docker info". Currently info endpoint isnt using the
GetAllByCap, but relies on existing networks to get the plugin names.
This causes a basic issue when it comes to global network plugins which
swarm-mode relies on, wherein swarmkit will not be able to schedule the
network on the worker nodes due to the filtering logic.

In order to break this chicken & egg issue, we must start to use the
GetAllManagedPluginsByCap. We are unable to use GetAllByCap due to
various issues with Plugin-V1's lazy loading approach causing issues
especially during daemon restarts (which uses SystemInfo)

Signed-off-by: Madhu Venugopal madhu@docker.com

@mavenugo mavenugo added this to the 1.13.0 milestone Jan 4, 2017
@thaJeztah thaJeztah added status/2-code-review status/failing-ci Indicates that the PR in its current state fails the test suite and removed status/0-triage labels Jan 4, 2017
@thaJeztah
Copy link
Member

CI looks to be failing;

13:16:18 --- FAIL: Test (3265.54s)
13:16:18 panic: DockerSwarmSuite.TestSwarmNetworkPlugin test timed out after 5m0s [recovered]
13:16:18 	panic: DockerSwarmSuite.TestSwarmNetworkPlugin test timed out after 5m0s
13:16:18 
13:16:18 goroutine 8 [running]:
13:16:18 panic(0x12257a0, 0xc42063e010)
13:16:18 	/usr/local/go/src/runtime/panic.go:500 +0x1a1
13:16:18 testing.tRunner.func1(0xc42007a840)
13:16:18 	/usr/local/go/src/testing/testing.go:579 +0x25d
13:16:18 panic(0x12257a0, 0xc42063e010)
...

@mavenugo
Copy link
Contributor Author
mavenugo commented Jan 4, 2017

@thaJeztah this will be solved by #29733 (once it is cherry-picked into 1.13.x branch). cc @cpuguy83 @vieux

@mavenugo
Swarmkit has enabled the plugin filtering logic based on the drivers
6924047 
returned in "docker info". Currently info endpoint isnt using the
GetAllByCap, but relies on existing networks to get the plugin names.
This causes a basic issue when it comes to global network plugins which
swarm-mode relies on, wherein swarmkit will not be able to schedule the
network on the worker nodes due to the filtering logic.

In order to break this chicken & egg issue, we must start to use the
GetAllManagedPluginsByCap. We are unable to use GetAllByCap due to
various issues with Plugin-V1's lazy loading approach causing issues
especially during daemon restarts (which uses SystemInfo)

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@vieux
Copy link
Contributor
vieux commented Jan 4, 2017

LGTM

1 similar comment
@tiborvass
Copy link
Contributor

LGTM

@tiborvass tiborvass added status/4-merge and removed status/2-code-review status/failing-ci Indicates that the PR in its current state fails the test suite labels Jan 4, 2017
@vieux vieux merged commit 7f20c11 into moby:1.13.x Jan 4, 2017
@anusha-ragunathan anusha-ragunathan mentioned this pull request Jan 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
52EF
Assignees
No one assigned
Labels
status/4-merge
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mavenugo @thaJeztah @vieux @tiborvass @GordonTheTurtle
0