8000 Split and remove pkg/stringutils by ChiuWang · Pull Request #35473 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Split and remove pkg/stringutils #35473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2017
Merged

Split and remove pkg/stringutils #35473

merged 1 commit into from
Nov 13, 2017

Conversation

ChiuWang
Copy link
Contributor
@ChiuWang ChiuWang commented Nov 13, 2017 •
edited
Loading

Signed-off-by: Chao Wang wangchao.fnst@cn.fujitsu.com

- What I did
Split the package first, see tasklist at #35313 and remove it safely now.
- How I did it
According to @thaJeztah 's suggestion at #35034(closed)

And maybe it should be added to the tasklist at Find a place for /pkg #32989 @dnephin

Split and remove pkg/stringutils
97e4066 
Signed-off-by: Chao Wang <wangchao.fnst@cn.fujitsu.com>
@vieux vieux mentioned this pull request Nov 13, 2017
Open
79 tasks
dnephin
dnephin approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member
@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

thaJeztah
thaJeztah approved these changes < 8000 span class="color-fg-muted"> Nov 13, 2017
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@thaJeztah thaJeztah merged commit aea31ab into moby:master Nov 13, 2017
@thaJeztah
Copy link
Member

oh, oops, saw you requested a review from @vdemeester as well; let me know if I merged too soon 😅

@ChiuWang
Copy link
Contributor Author
ChiuWang commented Nov 14, 2017 •
edited
Loading

@thaJeztah @dnephin You are welcome. If there's sth else that I 🐖 can help, plz @me. 😈

7DFA
@ChiuWang ChiuWang deleted the rm_stringutils branch November 14, 2017 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChiuWang @thaJeztah @dnephin @GordonTheTurtle
0