8000 remove deprecated pkg/loopback (utility package for devicemapper) by thaJeztah · Pull Request #47128 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove deprecated pkg/loopback (utility package for devicemapper) #47128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

remove deprecated pkg/loopback (utility package for devicemapper) #47128

merged 1 commit into from
Jan 22, 2024

Conversation

thaJeztah
Copy link
Member

relates to:

This package was introduced in af59752 as a utility package for devicemapper, which was removed in commit dc11d2a (v25.0.0), and the package was deprecated in bf692d4.

This patch removes the package.

- Description for the changelog

- Removed the deprecated `github.com/docker/docker/pkg/loopback` package.

- A picture of a cute animal (not mandatory but encouraged)

8000

@thaJeztah
remove deprecated pkg/loopback (utility package for devicemapper)
e2086b9 
This package was introduced in af59752
as a utility package for devicemapper, which was removed in commit
dc11d2a (v25.0.0), and the package
was deprecated in bf692d4.

This patch removes the package.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 19, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah
Copy link
Member Author

Failure on rootless is a known flaky #47119

=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.70s)

@AkihiroSuda AkihiroSuda merged commit 8528ed3 into moby:master Jan 22, 2024
@thaJeztah thaJeztah deleted the remove_pkg_loopback branch January 22, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@thaJeztah thaJeztah

Labels
area/storage/devicemapper impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @AkihiroSuda
0