8000 Dockerfile: update golangci-lint to v1.64.5 by thaJeztah · Pull Request #49481 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dockerfile: update golangci-lint to v1.64.5 #49481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Dockerfile: update golangci-lint to v1.64.5 #49481

merged 1 commit into from
Feb 18, 2025

Conversation

thaJeztah
Copy link
Member

Adds go1.24 support

full diff: golangci/golangci-lint@v1.63.4...v1.64.5
changelog: https://golangci-lint.run/product/changelog/#v1645

- Human readable description for the release notes



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  





       
            



      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @thaJeztah
  




      

        
          Dockerfile: update golangci-lint to v1.64.5
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          15fbd67
        
      

    

  

    

      
Adds go1.24 support

full diff: golangci/golangci-lint@v1.63.4...v1.64.5
changelog: https://golangci-lint.run/product/changelog/#v1645

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

    







  








      

  
            


    

    

      
    

    


      

          @thaJeztah
thaJeztah




              self-assigned this


      Feb 17, 2025

    

  








      

  
        





      

  
          
 
  

    
  

  


        
        @AkihiroSuda
  AkihiroSuda



        merged commit 28dc5a8
      into

      
  
    moby:master
  


    Feb 18, 2025

      

        154 of 156 checks passed
      


      

        
  
          
  
    
    


  
      

  












      

  
      



  

  @thaJeztah





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  
    

  




      


        


  
    

      
          
Oh! Erm, but CI was failing I see; https://github.com/moby/moby/actions/runs/13379016111/job/37364261172


integration/build/main_test.go:23:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/capabilities/main_linux_test.go:23:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/config/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/container/main_test.go:24:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/daemon/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/image/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/bridge/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/bridge/iptablesdoc/main_linux_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/ipvlan/main_test.go:24:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/macvlan/main_test.go:26:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/network/overlay/main_test.go:26:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/networking/main_test.go:23:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/plugin/authz/main_test.go:39:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/plugin/common/main_test.go:23:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/plugin/logging/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/plugin/volumes/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/secret/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/service/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/session/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/system/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration/volume/main_test.go:22:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
integration-cli/check_test.go:82:2: nested context in function literal (fatcontext)
	baseContext = ctx
	^
testutil/helpers.go:132:2: nested context in function literal (fatcontext)
	s.idx[t] = ctx
	^
testutil/helpers.go:141:2: nested context in function literal (fatcontext)
	s.idx[t] = ctx
	^



Looks like we should probably revert, then fix the issues before applying again 😅

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  
    

  




      


        


  
    

      
          
Having a look at fixing those; for the test ones, we probably should suppress, but I want to look if there's a better approach, so doing so through the golangci-lint config, instead of inline //nolint ones

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  


  

      

    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Feb 18, 2025
    





  


  

      
   Merged

  







  









      

  
      



  

  @thaJeztah





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  
    

  




      


        


  
    

      
          
      
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        bump_golangci_lint
    
    branch

    February 18, 2025 09:24    
    









      

  
      



  

  @AkihiroSuda





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  
    

  




      


        


  
    

      
          
Sorry, accidentally assumed that the CI was green 🙇‍♂️


Can we enable Require status checks to pass before merging ?


https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-status-checks-before-merging

      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  Author


  


  
    

  




      


        


  
    

      
          
Yes, I need to enable that for more; GitHub and test-matrixes don't play well together, but  probably for these it would work.


We may want to do a similar hack as Kir did for runc;


      <
8556
/td>
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    

      
    

    


      

          @thaJeztah
thaJeztah




          added this to the   28.0.0 milestone


      Mar 23, 2025

    

  












  
  

    

      

  




      


    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    

  

    Reviewers
  


    


        

          

  
      @AkihiroSuda
  
    AkihiroSuda



          
            
              
            
          
          AkihiroSuda approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
      @thaJeztah
  
    thaJeztah
    

      








      


  


  

    Labels
  



    

      

    area/testing

  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.



  
  
  



      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @thaJeztah 
        
          @AkihiroSuda 
    

  






    

    




    







  

    

  

  


    



  





    

  


  


          



    



  

    

    

    





    


    

    

  



0