Support ulimits on Swarm services. #41284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#41282 was merged; this needs a rebase now |
c1a0dea to
1f07e05
Compare
Includes moby/swarmkit#2967, which adds Ulimits to ContainerSpec. Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
|
Can you squash the last two commits? |
Add Ulimits field to the ContainerSpec API type and wire it to Swarmkit. This is related to moby#40639. Signed-off-by: Albin Kerouanton <albin@akerouanton.name>
1f07e05 to
c76f380
Compare
|
I rebased and squashed my commits 😉 |
|
Discussing with @cpuguy83 and we should be ok merging as-is; we can update if we think it has to move |
|
tldr; didn't want to hold this up and require the contributor to change, we can fix it if necessary. CapAdd/Drop would follow this same line of thinking as well. |
This was referenced Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
2E0D
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This is related to #40639.
- How I did it
- How to verify it
I tested my changes by updating docker/cli and using
docker service create|update|inspectanddocker stack deploy(I have to create that PR).- Description for the changelog
Support ulimits on Swarm services.
- A picture of a cute animal (not mandatory but encouraged)