8000 api/types: move swarm-related types to api/types/swarm by thaJeztah · Pull Request #50027 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

api/types: move swarm-related types to api/types/swarm #50027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 19, 2025
Merged

api/types: move swarm-related types to api/types/swarm #50027

merged 6 commits into from
May 19, 2025

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah commented May 19, 2025 •
edited
Loading

- Human readable description for the release notes

Go SDK: api/types: deprecate `NodeListOptions`, `NodeRemoveOptions`, `ServiceCreateOptions`, `ServiceUpdateOptions`, `RegistryAuthFromSpec`, `RegistryAuthFromPreviousSpec`, `ServiceListOptions`, `ServiceInspectOptions`, and `SwarmUnlockKeyResponse` which were moved to `api/types/swarm`

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review impact/deprecation area/swarm kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels May 19, 2025
@thaJeztah thaJeztah changed the title Move service types api/types: move swarm-related types to api/types/swarm May 19, 2025
thaJeztah added 3 commits May 19, 2025 13:41
@thaJeztah
api/types: move ServiceListOptions, ServiceInspectOptions to types/swarm
b135285 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
api/types: move NodeListOptions, NodeRemoveOptions to types/swarm
f008d85 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
api/types: move SwarmUnlockKeyResponse to api/types/swarm
7e8f630 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the move_service_types branch from 5479d44 to 441f220 Compare May 19, 2025 11:46
@thaJeztah thaJeztah marked this pull request as ready for review May 19, 2025 11:50
@thaJeztah thaJeztah requested a review from vvoland May 19, 2025 13:50
thaJeztah
thaJeztah commented May 19, 2025
View reviewed changes
api/types/client.go
}

// TaskListOptions holds parameters to list tasks with.
type TaskListOptions struct {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I missed adding an alias for this one; fixing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed ☝️

thaJeztah added 3 commits May 19, 2025 16:30
@thaJeztah
api/types: move TaskListOptions to api/types/swarm
5ad0867 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
api/types: move ServiceCreateOptions to api/types/swarm
31d6293 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
api/types: move ServiceUpdateOptions to api/types/swarm
0b1c7a8 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the move_service_types branch from 441f220 to 0b1c7a8 Compare May 19, 2025 14:30
@thaJeztah thaJeztah mentioned this pull request May 19, 2025
Merged
1 task
@thaJeztah thaJeztah requested a review from dmcgowan May 19, 2025 17:01
@thaJeztah
Copy link
Member Author

@dmcgowan ptal 🤗

@thaJeztah thaJeztah merged commit cbeec12 into moby:master May 19, 2025
141 checks passed
@thaJeztah thaJeztah deleted the move_service_types branch May 19, 2025 17:59
@thaJeztah thaJeztah mentioned this pull request May 19, 2025
Merged
@thaJeztah thaJeztah added this to the 28.2.0 milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@vvoland vvoland vvoland approved these changes

Assignees
No one assigned
Labels
area/go-sdk Changes affecting the Go SDK area/swarm impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Milestone
28.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @dmcgowan @vvoland
0