client: Use containerd errdefs to convert http errors #50030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
May 19, 2025
|
@vvoland this one can be rebased |
thaJeztah
reviewed
May 21, 2025
| @@ -5,6 +5,8 @@ import ( | |||
| ) | |||
|
|
|||
| // FromStatusCode creates an errdef error, based on the provided HTTP status-code | |||
| // | |||
| // Deprecated: Use [cerrdefs.ToNative] instead | |||
| func FromStatusCode(err error, statusCode int) error { | |||
There was a problem hiding this comment.
Can we make this wrap httpErrorFromStatusCode? That way the test would also cover that the behavior is un-modified.
There was a problem hiding this comment.
That would require moving it out of client to a shared package though. Possibly under internal, but that would make the errdefs depending on the internal.. (although that might not be such a big deal if it's going away?)
There was a problem hiding this comment.
oh! my mistake; I glanced over after I commented, and thought they were in the same package 😞
Previously, we were using our own `FromStatusCode` function to map HTTP status codes to Docker error types. Switch to the containerd code. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using our own
FromStatusCodefunction to map HTTP status codes to Docker error types. Switch to the containerd code.- A picture of a cute animal (not mandatory but encouraged)