8000 Composer install fails because of Git.php · Issue #356 · modmore/Gitify · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Composer install fails because of Git.php #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebastian-marinescu opened this issue Feb 11, 2021 · 4 comments · Fixed by #361
Closed

Composer install fails because of Git.php #356

sebastian-marinescu opened this issue Feb 11, 2021 · 4 comments · Fixed by #361

Comments

@sebastian-marinescu
Copy link
Contributor

Summary

Using composer install --no-dev the installation fails with the error-message:

Could not scan for classes inside “/opt/Gitify/vendor/kbjr/git.php/git.php” which does not appear to be a file nor a folder

( see https://forum.modmore.com/t/error-composer-install/2167/2 )

@Mark-H Git.php isn't acutally used inside Gitify anywhere, but by GitifyWatch, wasn't it?
@Mark-H
Copy link
Member
Mark-H commented Feb 11, 2021 •
edited
Loading

The git instance gets created inside Gitify but afaik yes, that only gets called from gitifywatch

https://github.com/modmore/Gitify/blob/master/src/Gitify.php#L107-L122

@sebastian-marinescu
Copy link
Contributor Author

I'll try to look into that issue in the next weeks, but if I don't find a solution, or the maintainer of Git.php isn't reacting, would you be open to switching to something like https://github.com/czproject/git-php ? (check out the author's name #insider)

@Mark-H
Copy link
Member
Mark-H commented Feb 11, 2021

Sure, would probably be ideal to reimplement it in Gitify Watch instead of Gitify and then just removing it from here.

@dbrumann dbrumann mentioned this issue May 3, 2021
Merged
@dbrumann
Copy link
Contributor
dbrumann commented May 3, 2021

I have created a quickfix that only removes the autoload section from the custom repository, which will then use autoloading defined in the external repository, where it was introduced in a recent pull request. If you have an existing installation you might have to manually remove the vendor folder first in order for the existing autoload not to be tainted.

adrorocker added a commit to adrorocker/Gitify that referenced this issue May 3, 2021
@adrorocker
Complementary fix of modmore#356
6032969 
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
@adrorocker adrorocker mentioned this issue May 3, 2021
Merged
Mark-H pushed a commit that referenced this issue May 3, 2021
@adrorocker
Complementary fix of #356 (#362)
751e169 
The PR that was made in [kbjr/Git.php](kbjr/Git.php#65) also changed the name of the methods on the `GitRepo` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix autoloading for git.php dbrumann/Gitify
3 participants
@Mark-H @dbrumann @sebastian-marinescu
0