8000 middleware: add LoggerConfig with Skipper func by kraem · Pull Request #9 · modfin/eal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

middleware: add LoggerConfig with Skipper func #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

middleware: add LoggerConfig with Skipper func #9

wants to merge 1 commit into from

Conversation

kraem
Copy link
@kraem kraem commented Oct 17, 2024

breaking change.

can handle both

CreateLoggerMiddleware(LoggerConfig{}, ...)

and

CreateLoggerMiddleware(DefaultLoggerConfig,, ...)

@kraem kraem requested review from joeledstrom and larsve October 17, 2024 13:14
larsve
larsve reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator
@larsve larsve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how many depends on EAL, but I would prefer to add this as a non-breaking change, i.e. add a new public method that take the new confg param and change CreateLoggerMidleware to return the result of the new method with an empty config.

@larsve
Copy link
Collaborator
larsve commented Oct 30, 2024

Maybe we should think of adding a second type of skipper, that just skip logging (unless there is an error). We use that to "mute" all logging of k8s health checks that otherwise would get logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsve larsve larsve left review comments

@joeledstrom joeledstrom Awaiting requested review from joeledstrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraem @larsve
0