8000 Bugs again by thesuzerain · Pull Request #703 · modrinth/code · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugs again #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Sep 12, 2023
Merged

Bugs again #703

merged 27 commits into from
Sep 12, 2023

Conversation

thesuzerain
Copy link
Contributor
@thesuzerain thesuzerain commented Sep 1, 2023 •
edited
Loading

Non issue adds:

  • Failure to launch screen with error message.
  • Minor export improvements ('remembering' settings, adding description)

Modpack
Fixes #194
Fixes #229
Fixes #505
Fixes #665 partially by setting it always to be 'required'. A full solution where options can be selected on export is needed still

Logs
Fixes #385
Fixes #387
Fixes #536
Fixes #593
Fixes #686
Fixes #698 (and notably deletes cache of old modrinth_logs)
Fixes #706

Neoforge
Fixes #684
Fixes #695
Fixes #702

Random
Fixes #272
Fixes #389 (for now just adds a little detail. If it doesnt help, we'll make it a separate point)
Fixes #470
Fixes #491
Fixes #498
Fixes #503
Fixes #527
Fixes #580
Fixes #588
Fixes #589
Fixes #591
Fixes #595 (both as an actual fix with unix standard and adds temporary code for loading versions exported this way)
Fixes #598
Fixes #603 (though perhaps will be further fixed by Jai's PR)
Fixes #605
Fixes #609
Fixes #621
fixes #623
Fixes #624
Fixes #626
Fixes #628
Fixes #662
Fixes #665
Fixes #666
Fixes #667
Fixes #681
Fixes #685
Fixes #687
Fixes #688
Fixes #689 (I think)

EDIT: (not 669 anymore)

Poopooracoocoo
Poopooracoocoo reviewed Sep 4, 2023
View reviewed changes
theseus_gui/src-tauri/tauri.conf.json Outdated
"minHeight": 700,
"minWidth": 1100,
"minHeight": 500,
"minWidth": 900,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could the minimum width please be decreased further? 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unfortunately going to be reverted for this PR. It's still going to be fixed/changed, but there are issues that crop up that need to all be sorted so will probably be pushed to the next PR

Geometrically
Geometrically requested changes Sep 5, 2023
View reviewed changes
Copy link
Member
@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed around half. it doesn't compile on mac yet so waiting for that

10000
Geometrically
Geometrically requested changes Sep 5, 2023
View reviewed changes
thesuzerain and others added 2 commits September 5, 2023 16:07
@thesuzerain
many revs
78b585c
@thesuzerain @qtchaos
Merge colorful logs (#725)
0713d65 
* make implementation not dumb

* run prettier

* null -> true

* Add line numbers & make errors more robust.

* improvments

* changes; virtual scroll

---------

Co-authored-by: qtchaos <72168435+qtchaos@users.noreply.github.com>
@thesuzerain thesuzerain marked this pull request as ready for review September 8, 2023 06:33
Geometrically
Geometrically requested changes Sep 11, 2023
View reviewed changes
Copy link
Member
@Geometrically Geometrically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Updating/changing modpack versions is pretty broken if you unlock the instance though.

If you install an old version fabulously optimized, unlock it, then update each mod individually or use the update all button, and then update the modpack, the mods will be installed twice. I believe this is because it is checking for versions and not projects.

I also think the update modpack button in the instance should use the change modpack versions modal. I think it will communicate to the user better what version they are installing and serves as a confirm modal.

Also, I think the 2 loading bars when updating/changing modpack version should be fixed. It is pretty confusing as a user.

theseus_gui/src/components/GridDisplay.vue
ref="instanceComponents"
:key="instance.path"
:key="instance.path + instance.install_stage"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this seems like a hacky workaround. i'll see if there's a better way when I do my commit

Geometrically
Geometrically requested changes Sep 11, 2023
View reviewed changes
Copy link
Member
@Geometrically Geometrically left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also think the design for the launcher error page can be improved a lot. See here:

image

Instead I think the layout should moreof replace the screen instead and look something like this (ignore colors ofc).

image
also the close button shouldn't show on mac

@thesuzerain thesuzerain merged commit 1e8852b into master Sep 12, 2023
@thesuzerain thesuzerain deleted the bugs-again branch September 12, 2023 16:27
@jriesen jriesen mentioned this pull request Sep 16, 2023
Closed
@JulianVennen JulianVennen mentioned this pull request Apr 25, 2024
Closed
Geometrically pushed a commit that referenced this pull request Oct 16, 2024
@triphora
Allow moderators to edit version info (#703)
e681802 
* Allow moderators to edit version info

* Clippy fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poopooracoocoo Poopooracoocoo Poopooracoocoo left review comments

@Geometrically Geometrically Geometrically approved these changes

@CodexAdrian CodexAdrian CodexAdrian approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@thesuzerain @Geometrically @Poopooracoocoo @CodexAdrian
0