Rails 5 support #6
Conversation
|
Nice work, Rob! It would be sweet to get this working on the latest version of Rails. Are you using this with MySQL or Postgresql? I noticed the generator is using MySQL for the legacy database connection, but we should probably update that to Postgresql since that's what most folks are using these days. |
|
@mokolabs moving from mysql to postgres as part of a Rails 2.3 to Rails 5 upgrade. Going to be doing that twice this month, so legacy being mysql makes sense to me... really it just needs to have some sort of default, it will likely need to be changed in a lot of cases. Not sure its critical to change which one you change things from. |
|
Legacy data is just another way of saying old data. It may or may not be in a different database system. Why don't we just copy the adapter settings from the development environment in database.yml? That way, if someone is using Postgres for their development database, the generated legacy adapter will use Postgres. If they're using MySQL for their development database, the legacy adapter will use MySQL. But this file is just generated as a convenience. If they need to switch from one database stack to another, they can just edit the generated adapter code and correct it as needed. (And we can add a FAQ note to the README for this). If that sounds good, I can work on this a bit later today. |
Trucker would not load in Rails 5, looks like legacy, non-Thor based generators have been dropped.