feat(charts): add ml-operator as a standalone chart #417
Conversation
|
@mdebarros any thoughts on this? |
There was a problem hiding this comment.
@lewisdaly, see my review comments.
I would also recommend creating separating your charts for each of your components (i.e. ml-operator and the image-watcher). I think it would be cleaner to maintain them separately, and rather have a parent composite chart where they can be deployed together.
Alternatively, if you do want them to run together, then I would suggest rather having them as part of the same deployment (i.e. two containers within the same pod).
Also, take note of the Redis dependency. I am happy its included as long as there is a config option to disable it and use an externally hosted Redis. <-- Note: We don't do this with the TTK, but I would say the TTK is "not" mission critical, and loss of data in that context is not really an issue. Regardless its a change we will need to make in future. With the ml-operator, I feel that having a reliable HA Redis would be important to the operations team.
Happy to jump on a call to discuss this in more detail.
Let me know your thoughts.
|
@mdebarros I've made a bunch of fixes to the charts. I ended up combining everything into 1 pod for now, just to keep things simple. |
Co-authored-by: Miguel de Barros <miguel@debarros.me>
|
thanks @mdebarros , I've committed that suggestion |
Co-authored-by: Miguel de Barros <miguel@debarros.me>
|
@mdebarros once more with vigour please! |
Co-authored-by: Miguel de Barros <miguel@debarros.me>
This is a first pass at adding the ml-operator to the Mojaloop helm charts. Mostly I've copied and pasted what we had in the ml-operator repo.
Followup (outside this PR)
values.ymlfilevalues.ymlfile, this seems to defeat the purpose of having secrets for me. I'm open for suggestions on how to do this however