internal: validate virtual pkg usage #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential memory issue in core dependency replacementCategory fn replace_virtual_pkg_core_with_impl_pkg_core(
m: &ModuleDB,
pkg: &Package,
core_deps: &mut Vec<String>,
)```
**Reasoning**
Changing from &mut Vec<String> to &mut [String] prevents the function from resizing the array if needed. While the current implementation works, it's more restrictive and could cause issues if future modifications require adding or removing elements.
</details>
<details>
<summary> Validation logic could be better organized </summary>
**Category**
Maintainability
**Code Snippet**
crates/moonutil/src/module.rs:524-622
pub fn validate_virtual_pkg(&self)
**Recommendation**
Split validation into smaller, focused functions:
```rust
impl ModuleDB {
fn validate_virtual_pkg(&self) -> anyhow::Result<()> {
self.validate_virtual_pkg_impl_constraints()?;
self.validate_virtual_pkg_overrides()?;
Ok(())
}
fn validate_virtual_pkg_impl_constraints(&self) -> anyhow::Result<()> {...}
fn validate_virtual_pkg_overrides(&self) -> anyhow::Result<()> {...}
}```
**Reasoning**
The current validate_virtual_pkg function is quite long and handles multiple concerns. Breaking it into smaller, focused functions would improve readability and maintainability while making the code easier to test.
</details>
<details>
<summary> Missing validation for circular implementation dependencies </summary>
**Category**
Correctness
**Code Snippet**
crates/moonutil/src/module.rs:524
pub fn validate_virtual_pkg(&self)
**Recommendation**
Add validation to detect circular dependencies:
```rust
fn check_circular_impl(&self, pkg: &Package, seen: &mut HashSet<String>) -> anyhow::Result<()> {
if let Some(impl_pkg) = &pkg.implement {
if !seen.insert(impl_pkg.clone()) {
bail!("Circular implementation dependency detected");
}
self.check_circular_impl(&self.get_package_by_name(impl_pkg), seen)?;
}
Ok(())
}```
**Reasoning**
The current validation doesn't prevent circular dependencies where package A implements B which implements C which implements A. This could lead to build issues or infinite recursion.
</details> |
bb4c758 to
ee4e4c0
Compare
ee4e4c0 to
9398a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.