fix: pass `-pkg-sources` of virtual pkg when build & check implement pkg #798

Young-Flash · 2025-05-07T08:04:23Z

No description provided.

peter-jerry-ye-code-review · 2025-05-07T08:04:38Z

Changed tuple structure without type alias

Category
Maintainability
Code Snippet
pub mi_of_virtual_pkg_to_impl: Option<(String, String, String)>
Recommendation
Create a type alias for the tuple structure:

type VirtualPackageInfo = (String, String, String); // (mi_path, pkg_name, pkg_path)
pub mi_of_virtual_pkg_to_impl: Option<VirtualPackageInfo>

Reasoning
The tuple structure (String, String, String) is used in multiple places and its meaning is not immediately clear. A type alias would improve code readability and make the purpose of each field more obvious.

Removed error message check in favor of partial match

Category
Correctness
Code Snippet
let content = get_err_stderr(&err, ["check"]);
assert!(content.contains("[$ROOT/lib1/lib1.mbti:5:1]"));
assert!(content.contains("[$ROOT/lib1/lib1.mbti:3:1]"));
Recommendation
Consider using a more precise error message check or document why partial matching is sufficient:

check(
    get_err_stderr(&err, ["check"]),
    expect![[r#"...[specific error pattern]..."#]]
);

Reasoning
Moving from exact error message matching to partial string matching could make tests more fragile to unrelated changes in error formatting. If the change is intentional, it should be documented why partial matching is preferred.

Redundant string cloning in command generation

Category
Performance
Code Snippet
mi_path.clone(), pkg_name.clone(), pkg_path.clone()
Recommendation
Use references where possible to avoid unnecessary string cloning:

format!("{name}:{path}", name=pkg_name, path=pkg_path)

Reasoning
Multiple clone() calls on strings during command generation could impact performance when building large projects. Using references or format! macro with named parameters could reduce memory allocations.

fix: pass -pkg-sources of virtual pkg when build & check implement pkg

f08b2d4

Young-Flash merged commit 9e0b1f2 into main May 7, 2025
5 of 13 checks passed

Young-Flash deleted the pkg-sources-of-virtual-pkg branch May 7, 2025 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: pass `-pkg-sources` of virtual pkg when build & check implement pkg #798

fix: pass `-pkg-sources` of virtual pkg when build & check implement pkg #798

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: pass -pkg-sources of virtual pkg when build & check implement pkg #798

fix: pass -pkg-sources of virtual pkg when build & check implement pkg #798

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: pass `-pkg-sources` of virtual pkg when build & check implement pkg #798

fix: pass `-pkg-sources` of virtual pkg when build & check implement pkg #798