internal: use md parser to extract test from .mbt.md #817

Young-Flash · 2025-05-20T06:44:33Z

No description provided.

peter-jerry-ye-code-review · 2025-05-20T06:44:57Z

Redundant default constructor pattern

Category
Maintainability
Code Snippet
pub struct DocTestExtractor {}

impl DocTestExtractor {
pub fn new(is_md_test: bool) -> Self { ... }
Recommendation
Since DocTestExtractor no longer needs any fields, consider making the extraction methods static or using a pure function approach
Reasoning
The empty struct with Default implementation adds unnecessary boilerplate. The functionality could be simplified by making the methods static or using pure functions since there's no state to maintain.

Multiple string allocations in Markdown code block extraction

Category
Performance
Code Snippet
current_code.push_str(&current_indent);
current_code.push_str(&text);
Recommendation
Pre-allocate the string buffer and/or use a string builder pattern for better performance
Reasoning
Multiple string concatenations in a loop can lead to repeated memory allocations. Pre-allocating or using a string builder pattern would be more efficient for larger documents.

Potential line counting error in Markdown code blocks

Category
Correctness
Code Snippet
let current_line = content[..range.start].chars().filter(|c| *c == '\n').count() + 1
Recommendation
Consider using a more robust line counting mechanism that handles all line ending types (\r\n, \n)
Reasoning
The current line counting implementation might not correctly handle different line endings, especially in Windows environments. This could lead to incorrect line numbers in error messages.

internal: use md parser to extract test from .mbt.md

ca3b18e

minor: tweak code

7525122

Young-Flash enabled auto-merge (squash) May 20, 2025 07:09

Young-Flash merged commit fad2523 into main May 20, 2025
13 checks passed

Young-Flash deleted the use_md_parser branch May 20, 2025 07:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

internal: use md parser to extract test from .mbt.md #817

internal: use md parser to extract test from .mbt.md #817

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

internal: use md parser to extract test from .mbt.md #817

internal: use md parser to extract test from .mbt.md #817

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!