8000 internal: remove deprecated --md flag for moon test by Young-Flash · Pull Request #823 · moonbitlang/moon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

internal: remove deprecated --md flag for moon test #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

internal: remove deprecated --md flag for moon test #823

merged 1 commit into from
May 22, 2025

Conversation

Young-Flash
Copy link
Collaborator

No description provided.

@Young-Flash Young-Flash enabled auto-merge (squash) May 22, 2025 09:43
@peter-jerry-ye-code-review peter-jerry-ye code review
Copy link
Incomplete cleanup of deprecated feature

Category
Maintainability
Code Snippet
test_run_md_test() function in tests/test_cases/mod.rs still contains references to removed --md flag in test names
Recommendation
Rename the test function and update its documentation to reflect that markdown testing is now part of the main test functionality
Reasoning
The test function name still implies a separate markdown test feature, which could be confusing for future maintainers since the --md flag has been removed

Documentation update needed

Category
Maintainability
Code Snippet
Both manual/src/commands.md and manual-zh/src/commands.md had the --md flag removed
Recommendation
Add a note in the documentation explaining that markdown tests are now automatically included in the regular test command
Reasoning
Users migrating from older versions need to understand that markdown testing functionality still exists but is now integrated into the main test command

Potential regression in test coverage validation

Category
Correctness
Code Snippet
run_test function no longer checks for cmd.md_test
Recommendation
Verify that all markdown test cases are still being executed through the main test path
Reasoning
Removing the separate flag path should not impact test coverage - need to ensure the main test functionality properly handles markdown files

@Young-Flash Young-Flash merged commit 85e0e44 into main May 22, 2025
13 checks passed
@Young-Flash Young-Flash deleted the remove--md branch May 22, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Young-Flash
0