improve Array::makei #1753
improve Array::makei #1753
Conversation
Uses the same implementation as Array::make, which is panic when len < 0.
Pull Request Test Coverage Report for Build 5598Details
💛 - Coveralls |
|
Maybe you can just make |
| if length <= 0 { | ||
| [] | ||
| } else { | ||
| let array = Array::make(length, value(0)) |
There was a problem hiding this comment.
I want to avoid redundent fill values Array::make(length, value(0))
There was a problem hiding this comment.
I don't see why it's redundent: when you have Array::make_uninit, it also has this fill operation, except it's filled with some other value.
The only thing that may change is the performance difference between set and unsafe_set.
There was a problem hiding this comment.
Array::make has two fill operations.
Array::makei call Array::make has three fill operations,
pub fn Array::make[T](len : Int, elem : T) -> Array[T] {
let arr = Array::make_uninit(len) // (1)
for i in 0..<len {
arr.unsafe_set(i, elem) // (2)
}
arr
}
pub fn Array::makei[T](length : Int, value : (Int) -> T) -> Array[T] {
if length <= 0 {
[]
} else {
let array = Array::make(length, value(0)) // (2)
for i in 1..<length {
array[i] = value(i) // (3)
}
array
}
}There was a problem hiding this comment.
@Yu-zh Do we have intrinsics for these cases?
I also want to use |
So how to copy them to the |
|
Copy them as well. |
|
Array related implementation will be moved to |
Uses the same implementation as Array::make, which is panic when len < 0.