You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, methods defined as fn f(self : T, ..) are considered both method and regular function. While this allows convenient ways of calling method via @pkg.meth(..), it also complicates the semantic of MoonBit.
The latest release of MoonBit now supports partial dot application (_.meth(..)) and piping into dot application (expr |> _.meth(..)), which significantly reduce the need for calling methods as regular functions. So we decided to deprecate the behavior of calling methods as regular functions, to simplify the language.
This PR removes usage of calling method as regular function in core. In next week's release, we will start emitting warnings on such usage. We are also simplifying the syntax of MoonBit's method system, the simplified syntax will also be available next week.
For most cases, this PR just migrates regular function apply to dot apply. However, for math related methods (Double::sin, for example), people are more used to function call style sin(..) from math notation, compared of dot apply style xx.sin(). So an fnalias is provided for math related functions and several others, such as Ref::swap.
Inconsistent handling of `sin`, `cos` and other math functions in string format
Category
Correctness Code Snippet
pub fnalias Float::(sin, cos, tan, asin, acos, atan, atan2...) Recommendation
Should extract common math functions into a separate shared list and reuse it between Float and Double Reasoning
Mathematical functions are duplicated between Float and Double modules. Having them defined separately increases the risk of inconsistency and makes maintenance harder.
Missing documentation for the new `fnalias` syntax
Category
Maintainability Code Snippet
pub fnalias Double::(sin, cos, tan...) Recommendation
Add documentation explaining the fnalias syntax and its intended usage with examples Reasoning
The new fnalias syntax is a significant language feature but lacks documentation about its purpose and proper usage, which could lead to confusion
Inconsistent patch style in test migrations
Category
Style Guide Complicance Code Snippet
inspect(@double.is_nan(result), content="true") -> inspect(result.is_nan(), content="true") Recommendation
Use consistent style for test migrations - either chain method calls or use temporary variables Reasoning
The test migrations show inconsistent styles - some use method chaining while others use intermediate variables. A consistent style would improve readability.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, methods defined as
fn f(self : T, ..)are considered both method and regular function. While this allows convenient ways of calling method via@pkg.meth(..), it also complicates the semantic of MoonBit.The latest release of MoonBit now supports partial dot application (
_.meth(..)) and piping into dot application (expr |> _.meth(..)), which significantly reduce the need for calling methods as regular functions. So we decided to deprecate the behavior of calling methods as regular functions, to simplify the language.This PR removes usage of calling method as regular function in core. In next week's release, we will start emitting warnings on such usage. We are also simplifying the syntax of MoonBit's method system, the simplified syntax will also be available next week.
For most cases, this PR just migrates regular function apply to dot apply. However, for math related methods (
Double::sin, for example), people are more used to function call stylesin(..)from math notation, compared of dot apply stylexx.sin(). So anfnaliasis provided for math related functions and several others, such asRef::swap.