Add truncate to array and join/drain/flatten to deque #2191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing guard condition return value in UninitializedArray::blitCategory guard len >= 0 &&
dst_offset >= 0 &&
src_offset >= 0 &&
dst_offset <= dst.length() &&
src_offset + len <= self.length() else { return dst }```
**Reasoning**
The guard statement lacks a return value when the conditions fail. Since the function must return a UninitializedArray, we should return the original dst array to maintain consistent behavior.
</details>
<details>
<summary> Potential double allocation in Deque::join implementation </summary>
**Category**
Performance
**Code Snippet**
let str = separator.to_string()
self.iter().join(str)
**Recommendation**
Consider passing the string view directly to avoid unnecessary allocation:
```moonbit
self.iter().join(separator)```
**Reasoning**
Converting the string view to a string before joining creates an unnecessary allocation. The iterator's join operation should be able to work directly with string views.
</details>
<details>
<summary> Complex nested logic in Deque::drain without intermediate variables </summary>
**Category**
Maintainability
**Code Snippet**
ignore(
self.buf.blit(
self.buf,
len=self.length() - end,
src_offset=end,
dst_offset=start,
),
)
**Recommendation**
Break down the complex operation into named intermediate steps:
```moonbit
let remaining_len = self.length() - end
let _ = self.buf.blit(
self.buf,
len=remaining_len,
src_offset=end,
dst_offset=start
)```
**Reasoning**
The current implementation nests multiple operations making it harder to understand and debug. Using intermediate variables improves readability and makes the code's intent clearer.
</details> |
Pull Request Test Coverage Report for Build 68Details
💛 - Coveralls |
bobzhang
previously requested changes
May 31, 2025
Change implementation of deque::join Change truncate from function to array method Change join,drain,flatten from function to deque method
|
@bobzhang,I just wanted to check if there are any unresolved issues with this PR. |
peter-jerry-ye
approved these changes
Jun 20, 2025
Co-authored-by: Zihang Ye <jerryzihye@outlook.com>
|
I just need more tests and verify the implementation of |
peter-jerry-ye
requested changes
Jun 26, 2025
|
You suggested changing the parameter names from |
peter-jerry-ye
approved these changes
Jun 26, 2025
|
Thank you. |
peter-jerry-ye
added a commit
that referenced
this pull request
Jun 27, 2025
peter-jerry-ye
added a commit
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.