Fix int64 random mask #2248
Fix int64 random mask #2248
Conversation
The original mask implementation was incorrect for generating 63-bit integersCategory Consider adding range specifications in commentsCategory Test case update could include range verificationCategory test "int64_bounds" {
let r = Rand.from_seed(42)
let val = r.int64()
assert(val >= 0)
assert(val < (1L << 63))
}
**Reasoning**
Single-value testing doesn't verify the range constraints. Adding boundary tests would ensure the implementation maintains its contract across changes.
</details> |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the behavior of the int64 random value generation by revising the bit mask computation and adjusting associated tests and documentation.
- Updates the int64 mask calculation in random.mbt to compute (1UL << 63) - 1UL
- Revises the expected int64 output in both random_test.mbt and README.mbt.md
- Aligns test expectations to the new mask behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| random/random_test.mbt | Updated expected int64 output in tests |
| random/random.mbt | Revised bit mask calculation for int64 method |
| random/README.mbt.md | Updated int64 expected output in documentation |
Comments suppressed due to low confidence (2)
random/random.mbt:106
- Update the comment to clearly indicate that this mask extracts the lower 63 bits, ensuring that it accurately reflects the new implementation and intended behavior.
let mask : UInt64 = (1UL << 63) - 1UL
random/random_test.mbt:25
- Verify that the updated expected int64 value aligns precisely with the deterministic output of the new mask computation in Rand.int64 to avoid future test inconsistencies.
assert_eq(r.int64(), 2043189202271773519)
Pull Request Test Coverage Report for Build 7212Details
💛 - Coveralls |
bcad894 to
6adff7b
Compare
Summary
Rand.int64int64output in READMErandom_test.mbtaccordinglyTesting
moon cleanmoon testhttps://chatgpt.com/codex/tasks/task_e_6849493e451c832094e278729b3ed52d