8000 ci: remove job `moon test --doc ` by Young-Flash · Pull Request #2294 · moonbitlang/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: remove job moon test --doc #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

ci: remove job moon test --doc #2294

merged 1 commit into from
Jun 18, 2025

Conversation

Young-Flash
Copy link
Contributor

No description provided.

@Young-Flash Young-Flash enabled auto-merge (squash) June 18, 2025 03:10
Copy link
Removal of documentation testing without apparent replacement

Category
Correctness
Code Snippet

  • name: moon test --doc
    run: |
    moon test --doc
    Recommendation
    If documentation testing is still needed, consider either:
  1. Moving it to a separate workflow job
  2. Adding a comment explaining why it was removed
  3. Re-implementing it in a more efficient way
    Reasoning
    Documentation tests are important for maintaining code quality and ensuring examples in documentation stay up-to-date. Removing them without replacement could lead to documentation drift.
Duplicate job removal in workflow

Category
Maintainability
Code Snippet
The same moon test --doc step was removed from two different jobs
Recommendation
If this is a temporary removal, add a TODO comment explaining the plan for reimplementing documentation testing. If it's permanent, update related documentation to reflect this change.
Reasoning
Changes to CI/CD processes should be well-documented to help other developers understand the testing coverage and requirements.

Potential CI pipeline optimization

Category
Performance
Code Snippet
Both jobs still contain moon test and moon check commands
Recommendation
Consider combining related test commands or running them in parallel if they're independent to optimize CI runtime
Reasoning
CI pipeline efficiency is important for developer productivity. If documentation tests were removed for performance reasons, there might be other opportunities for optimization.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7355

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.629%

Totals Coverage Status
Change from base Build 7354: 0.0%
Covered Lines: 8612
Relevant Lines: 9198

💛 - Coveralls

@Young-Flash Young-Flash merged commit 44c8d2b into main Jun 18, 2025
12 checks passed
@Young-Flash Young-Flash deleted the minor branch June 18, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0