8000
Move deprecated blocks in string package by bobzhang · Pull Request #2318 · moonbitlang/core · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider adding migration guide in deprecation notices
Category
Maintainability Code Snippet
#deprecated("Use s.find(substr) instead. If the optional argument from is not 0, take view from the string first. Please do not use an invalid from argument.") Recommendation
Include code example in deprecation message, e.g.: #deprecated("Use s.find(substr) instead. Example: Replace index_of(s, 'x', 5) with s.view(start_offset=5).find('x').") Reasoning
Complex migration paths are harder to understand without concrete examples. Adding example transformations makes it clearer how to update existing code.
Size hint calculation in concat() may overflow
Category
Performance Code Snippet
size_hint = size_hint << 1 Recommendation
Add overflow check or use a more conservative growth strategy: size_hint = if size_hint > MAX_INT/2 { MAX_INT } else { size_hint << 1 } Reasoning
Left shifting integers can cause overflow with large arrays. Even though this is deprecated code, it should still handle edge cases safely.
Inconsistent handling of empty strings in index functions
Category
Correctness Code Snippet
if str.length() == 0 { self.length() } else { -1 } Recommendation
Consider consistent behavior - either always return -1 for out of bounds or always handle empty string as a special case Reasoning
The current code returns different values for empty strings based on the from parameter, which could be confusing. Consistency would make the behavior more predictable.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deprecated.mbtstring.mbtandview.mbtstring.mbtTesting
moon fmtmoon infomoon testmoon checkhttps://chatgpt.com/codex/tasks/task_e_685963c08e6c83208721f1364ce6039a