8000
chore: improve coverage for immut/hashset by Lampese · Pull Request #2310 · moonbitlang/core · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyString implements Show twice with different methods
Category
Correctness Code Snippet
impl Show for MyString with to_string(self) {...}
impl Show for MyString with output(self, logger) {...} Recommendation
Combine the Show implementations into a single impl block or remove one if redundant Reasoning
Having multiple implementations of the same trait can lead to ambiguity and potential runtime issues. The two Show implementations should be consolidated for clarity and correctness.
Hash implementation for MyString always returns constant value
Category
Maintainability Code Snippet
impl Hash for MyString with hash_combine(_self, hasher) {
hasher.combine(1)
} Recommendation
Use the actual string content for hashing: hasher.combine(self.inner().hash()) Reasoning
Using a constant hash value (1) for all strings defeats the purpose of hash-based collections and will lead to unnecessary collisions. While this might be intentional for testing, it should be documented if so.
Test descriptions could be more descriptive
Category
Maintainability Code Snippet
test "HAMT::union with empty" {...}
test "HAMT::union with leaf" {...} Recommendation
Add more descriptive test names that explain the expected behavior, e.g. "HAMT::union with empty set should return the non-empty set" Reasoning
More descriptive test names serve as documentation and make it easier to understand test failures without diving into the implementation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.