8000 disable stable-check in macos-13 when pull requesting by myfreess · Pull Request #2346 · moonbitlang/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

disable stable-check in macos-13 when pull requesting #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

disable stable-check in macos-13 when pull requesting #2346

merged 1 commit into from
Jun 25, 2025

Conversation

myfreess
Copy link
Contributor

No description provided.

@peter-jerry-ye-code-review peter-jerry-ye code review
Copy link
peter-jerry-ye-code-review bot commented Jun 25, 2025 •
edited
Loading
Duplicate test commands across workflows

Category
Maintainability
Code Snippet
moon test --target native --release (appears multiple times in both bleeding-check.yml and stable-check.yml)
Recommendation
Extract common test commands into a composite action or reusable workflow
Reasoning
The same test commands are repeated across workflows. Creating a reusable component would reduce duplication and make maintenance easier when test commands need to be updated.

Stack size limit might need adjustment per platform

Category
Correctness
Code Snippet
ulimit -s 8176
Recommendation
Consider making the stack size configurable per OS or documenting why 8176 was chosen
Reasoning
Hard-coded stack size limits might not be optimal for all platforms and test scenarios. Making this configurable would provide more flexibility and clarity about resource requirements.

Inconsistent version installation between stable and bleeding builds

Category
Maintainability
Code Snippet
curl -fsSL https://cli.moonbitlang.com/install/unix.sh | bash -s bleeding vs curl -fsSL https://cli.moonbitlang.com/install/unix.sh | bash
Recommendation
Use an environment variable to control the version consistently across all workflows
Reasoning
Having the version parameter handled differently between workflows makes it harder to maintain. Using an environment variable would provide a single point of control for version management.

@coveralls
Copy link
Collaborator
coveralls commented Jun 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 28

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.332%
Totals Coverage Status
Change from base Build 23: 0.0%
Covered Lines: 3517
Relevant Lines: 3937
💛 - Coveralls

@myfreess myfreess force-pushed the myfreess/improve-ci branch 3 times, most recently from 737dd20 to 0759730 Compare June 25, 2025 10:04
@myfreess myfreess force-pushed the myfreess/improve-ci branch from 0759730 to e993904 Compare June 25, 2025 10:16
@bobzhang bobzhang merged commit a8107e6 into main Jun 25, 2025
10 checks passed
@bobzhang bobzhang deleted the myfreess/improve-ci branch June 25, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myfreess @coveralls @bobzhang
0