8000
refactor: remove loop vars that are not updated by Yu-zh · Pull Request #2358 · moonbitlang/core · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent improvement in loop syntax across files
Category
Maintainability Code Snippet
Changed from:
for i = 0, len = arr.length(); i < len; i = i + 1
to:
for i in 0..<arr.length() Recommendation
The changes are good. Consider updating any remaining C-style loops in the codebase for consistency. Reasoning
The new range-based syntax is more concise, more readable, and less error-prone as it eliminates the need for manual increment and bound checking.
Range operator usage needs validation
Category
Correctness Code Snippet
0..<arr.length() Recommendation
Verify that the half-open range operator (..<) is inclusive of the start and exclusive of the end value as intended. Reasoning
When changing loop constructs, it's critical to ensure the iteration bounds remain exactly the same. The half-open range should iterate up to but not including arr.length().
Documentation update needed
Category
Maintainability Code Snippet
Multiple files including fixedarray_sort.mbt, iter_test.mbt, and bytes.mbt Recommendation
Add comments or update existing documentation to reflect the new loop syntax where relevant. Reasoning
Documentation should be updated to match the actual code syntax, especially in example code sections, to avoid confusion for new developers.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.