You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Category
Correctness Code Snippet
fn[K : Eq, V] get_with_hash(self : T[K, V], key : K, hash : Int) -> V? Recommendation
The Hash trait removal appears correct since the hash is passed as parameter, but document why Hash isn't needed Reasoning
It's important to explicitly document when a trait bound is intentionally omitted despite the function dealing with hash values, to prevent accidental reintroduction of the bound in future
Consider documenting trait bound changes in API docs
Category
Maintainability Code Snippet
pub fn[A] new() -> T[A] { ... } Recommendation
Add documentation noting that the function intentionally has no trait bounds to make it more flexible Reasoning
API documentation should explain design decisions around type constraints to help users understand what is required vs. optional
Some trait bound removals may affect maintainability of balance functions
Category
Maintainability Code Snippet
fn[K, V] balance(key : K, value : V, l : T[K, V], r : T[K, V]) -> T[K, V] Recommendation
Consider keeping Compare bound and documenting that it may be needed for future tree balancing optimizations Reasoning
Balance functions in tree structures often need ordering comparisons. While not currently used, removing the bound may make future optimizations harder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unused trait bound in core, using unused warning for trait bounds, which is currently under development in MoonBit compiler.