8000 rational: fix invariants, simplify implementation, clean up tests by FlyCloudC · Pull Request #2379 · moonbitlang/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rational: fix invariants, simplify implementation, clean up tests #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

rational: fix invariants, simplify implementation, clean up tests #2379

merged 3 commits into from
Jun 30, 2025

Conversation

FlyCloudC
Copy link
Contributor
  1. Fixed invariant violations in the arbitrary impl
  2. Optimized implementation using invariants
  3. Removed duplicate tests

@coveralls
Copy link
Collaborator
coveralls commented Jun 29, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 153

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.386%
Totals Coverage Status
Change from base Build 152: 0.0%
Covered Lines: 3453
Relevant Lines: 3863
💛 - Coveralls

@peter-jerry-ye
Copy link
Collaborator

FYI: we are going to move this package out of core

@peter-jerry-ye peter-jerry-ye enabled auto-merge (rebase) June 30, 2025 02:19
@peter-jerry-ye peter-jerry-ye merged commit ba192be into moonbitlang:main Jun 30, 2025
10 checks passed
@FlyCloudC FlyCloudC deleted the fix-rational branch July 2, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-jerry-ye peter-jerry-ye peter-jerry-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlyCloudC @coveralls @peter-jerry-ye
0