hongbo/test bytes using regex #2418

bobzhang · 2025-07-07T13:30:00Z

test: Add regex matching test for string pattern
fix(regex): update regex match syntax for clarity and correctness

peter-jerry-ye-code-review · 2025-07-07T13:30:15Z

Potential syntax error in regex pattern matching

Category
Correctness
Code Snippet
match "hell123o" using regex {
["hell[0-9]+" as x, .. rest] => {
guard x is "hell123" && rest is "o" else { fail("Regex match failed") }
}
Recommendation
Verify the regex syntax is correct for MoonBit. Consider using a more standard regex pattern syntax like /hell[0-9]+/ or ensure the string literal regex format is properly supported by the language
Reasoning
The regex pattern syntax using string literals in array-like destructuring is unusual and may not be valid. Most languages use delimited regex patterns or dedicated regex constructors.

Inconsistent formatting style with existing codebase

Category
Maintainability
Code Snippet
content=(
#|b"\xe4\xbd\xa0\xe5\xa5\xbd\x75\x74\x66\x38\xe4\xbd\xa0\xe5\xa5\xbd"
),
Recommendation
Keep the original formatting style without parentheses around content parameter to maintain consistency with the existing codebase pattern
Reasoning
The changes add parentheses around multiline content parameters, but this creates inconsistency if other parts of the codebase use the original format. Style changes should be applied consistently across the entire codebase.

Missing error handling for regex compilation

Category
Correctness
Code Snippet
test "using regex" {
match "hell123o" using regex {
["hell[0-9]+" as x, .. rest] => {
Recommendation
Add error handling for potential regex compilation failures and consider testing edge cases like invalid patterns or non-matching strings
Reasoning
The test doesn't handle cases where the regex might fail to compile or match. Robust regex tests should cover both positive and negative cases.

bobzhang added 2 commits July 7, 2025 21:29

test: Add regex matching test for string pattern

3979bd2

fix(regex): update regex match syntax for clarity and correctness

5c545b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

hongbo/test bytes using regex #2418

hongbo/test bytes using regex #2418

Uh oh!

Uh oh!

Uh oh!

hongbo/test bytes using regex #2418

Are you sure you want to change the base?

hongbo/test bytes using regex #2418

Conversation

Uh oh!

Uh oh!

Uh oh!