8000 fmt by bobzhang · Pull Request #2420 · moonbitlang/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fmt #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fmt #2420

merged 1 commit into from
Jul 9, 2025

Conversation

bobzhang
Copy link
Contributor
@bobzhang bobzhang commented Jul 8, 2025

No description provided.

Copy link
Inconsistent formatting style for inspect function content parameter

Category
Maintainability
Code Snippet
Lines throughout both files:
// Before:
content=
#|["b", "aa", "ccc"]
,

// After:
content=(
#|["b", "aa", "ccc"]
),
Recommendation
The new format with parentheses is more consistent and readable. Ensure this formatting style is documented in the project's style guide and applied consistently across all documentation files.
Reasoning
Consistent code formatting improves readability and reduces cognitive load for developers. The parentheses-wrapped format is clearer about parameter boundaries.

Consider automated formatting to prevent future inconsistencies

Category
Maintainability
Code Snippet
Multiple instances across array/README.mbt.md and buffer/README.mbt.md showing manual formatting changes
Recommendation
Implement automated code formatting (like moonbit fmt if available) in the CI pipeline to ensure consistent formatting across all documentation and code files.
Reasoning
Manual formatting changes like this indicate a need for automated tooling to maintain consistency and reduce the burden of style-related pull requests.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 263

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.151%

Totals Coverage Status
Change from base Build 258: 0.0%
Covered Lines: 3476
Relevant Lines: 3899

💛 - Coveralls

@bobzhang bobzhang merged commit b163067 into main Jul 9, 2025
10 checks passed
@bobzhang bobzhang deleted the hongbo/test_new_release branch July 9, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0