Allow nikic/php-parser v5 to be used once we move to php80 as requirement #88
Comments
stronk7
added a commit
to stronk7/moodle-cs
that referenced
this issue
Jan 11, 2024
It seems that both phpunit and php-code-coverage have started to accept nikic/php-parser v5, but that's leading to problems with PHP 7.4 runs, that we still support. So, with this commit, we are locking nikic/php-parser v4 Once we officially make moodle-cs to only support php >= 8.0 we can remove this lock. Issue: moodlehq#88
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
It seems that both phpunit and php-code-coverage have
started to accept nikic/php-parser v5, but that's leading
to problems with PHP 7.4 runs, that we still support.
So, with this commit, we locked nikic/php-parser v4: 6eb7253 in January 2024.
Once we officially make moodle-cs to only support php >= 8.0
we can remove this lock (basically, remove the commit above).
This issue will be in charge of that.
The text was updated successfully, but these errors were encountered: