refactor: remove devshell; add formatter; cleanup #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it should. `pkgs.mkShell` is a healthier way to create a nix shell with your chosen programs and shell hooks. `devshell` isn't really needed in this case since you can reasonably achieve everything here by adding the shell hook and the packages to `pkgs.mkShell` while also making the flake needlessly larger. I also added a formatter (with some probably devilish tricks) to format the flake without needing to use treefmt or other unneeded tree formatting solutions. I additionally reworked the inputs a small fraction to reduce the size of the flake (using follows consistently for example). No, not really.
930e4b5 to
b6f6ba0
Compare
|
Thank you for the PR! Truth be told, I haven't got much value out of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this break anything?
I don't think it should.
What does this change/add/delete?
pkgs.mkShellis a healthier way to create a nix shell with your chosen programs and shell hooks.devshellisn't really needed in this case since you can reasonably achieve everything here by adding the shell hook and the packages topkgs.mkShellwhile also making the flake needlessly larger.I also added a formatter (with some probably devilish tricks) to format the flake without needing to use treefmt or other unneeded tree formatting solutions.
I additionally reworked the inputs a small fraction to reduce the size of the flake (using follows consistently for example).
Do I intend to add more commits to this PR?
No, not really.