NTR: fix apple pay direct click and refactor express buttons #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8ea44c to
fa1b708
Compare
dd0091b to
e38fd7a
Compare
8d63f86 to
65fd623
Compare
65fd623 to
44b677b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the double-click requirement for Apple Pay Direct and refactors the express payment flow by consolidating shared services, enforcing a data protection checkbox, and updating tests accordingly.
- Introduce
ShopConfigurationmodel and extendShopConfigurationActionto include a privacy flag - Add
getDataPrivacyCheckboxmethods to repositories and enforce privacy validation in express plugins - Refactor express payment plugins into shared services (e.g.,
PrivacyNotesService,AddToCartService,ProductBoxValidator) and update registration paths - Update e2e tests to cover data protection acceptance scenarios for PayPal Express and Apple Pay Direct
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Cypress/.../support/repositories/.../PDPRepository.js | Added getDataPrivacyCheckbox for data protection support |
| tests/Cypress/.../support/models/ShopConfiguration.js | New ShopConfiguration model to manage privacy state |
| tests/Cypress/.../support/actions/admin/ShopConfigurationAction.js | Extended setupShop to accept ShopConfiguration and apply it |
| tests/Cypress/cypress/e2e/.../paypal-express.cy.js | Updated tests to include privacy acceptance and DRY setup |
| tests/Cypress/cypress/e2e/.../applepay-direct.cy.js | Updated Apple Pay Direct tests for privacy scenarios |
| src/Resources/app/.../services/express/privacy-notes.service.js | New service to toggle privacy notes for express buttons |
| src/Resources/app/.../services/express/add-to-cart.service.js | New synchronous add-to-cart service for express |
| src/Resources/app/.../plugins/express/paypal-express.plugin.js | Refactored PayPal Express plugin to use new services |
| CHANGELOG.md | Added entry for Apple Pay Direct click fix |
Comments suppressed due to low confidence (1)
CHANGELOG.md:32
- [nitpick] The changelog entry covers only the Apple Pay Direct double-click fix; please add a note about the new data protection checkbox requirement introduced for express payments.
- Fix problem where Apple Pay Direct had to be clicked twice to start the payment.
src/Resources/app/storefront/src/mollie-payments/services/express/add-to-cart.service.js
Show resolved
Hide resolved
tests/Cypress/cypress/e2e/storefront/payment-methods/applepay-direct.cy.js
Show resolved
Hide resolved
tests/Cypress/cypress/e2e/storefront/payment-methods/paypal-express.cy.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.