8000 [2020-02] Add missing handle function enter/return macros by github-actions[bot] · Pull Request #21407 · mono/mono · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[2020-02] Add missing handle function enter/return macros #21407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

[2020-02] Add missing handle function enter/return macros #21407

merged 1 commit into from
Jan 24, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #21405 to 2020-02

/cc @lambdageek @joshpeterson

Add missing handle function enter/return macros
8000
c78fa9f 
The mono_field_static_get_value method uses a handle, but did not set up
enter/exit macros properly, so this handle was leaked.

Some code in Unity calls this embedding API method pretty often, which
can lead to the mark stack overflowing in the GC code.
@lambdageek
Copy link
Member

@monojenkins build

@lambdageek lambdageek merged commit 9f35bf1 into 2020-02 Jan 24, 2022
@akoeplinger akoeplinger deleted the backport/pr-21405-to-2020-02 branch January 24, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lambdageek
0