Avoid an assert in ves_icall_RuntimeFieldInfo_SetValueInternal #21410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the field is byref but the value being passes in is not, throw an ArgumentException. Without this change the call to mono_object_handle_pin_unbox will assert and kill the process. This can occur when de-serializing an object and the field types have changed.
lambdageek
approved these changes
Jan 25, 2022
|
@monojenkins build failed |
|
/backport to 2020-02 |
|
Started backporting to 2020-02: https://github.com/mono/mono/actions/runs/1780827214 |
bholmes
added a commit
to Unity-Technologies/mono
that referenced
this pull request
Feb 3, 2022
…21410) When the field is byref but the value being passes in is not, throw an ArgumentException. Without this change the call to mono_object_handle_pin_unbox will assert and kill the process. This can occur when de-serializing an object and the field types have changed. Co-authored-by: bholmes <bholmes@users.noreply.github.com>
hannem-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Apr 26, 2022
…21410) When the field is byref but the value being passes in is not, throw an ArgumentException. Without this change the call to mono_object_handle_pin_unbox will assert and kill the process. This can occur when de-serializing an object and the field types have changed. Co-authored-by: bholmes <bholmes@users.noreply.github.com>
hannem-rythmos
pushed a commit
to Unity-Technologies/mono
that referenced
this pull request
Apr 26, 2022
…21410) When the field is byref but the value being passes in is not, throw an ArgumentException. Without this change the call to mono_object_handle_pin_unbox will assert and kill the process. This can occur when de-serializing an object and the field types have changed. Co-authored-by: bholmes <bholmes@users.noreply.github.com>
ThomasKuehne
pushed a commit
to ThomasKuehne/mono
that referenced
this pull request
Mar 23, 2024
…21410) When the field is byref but the value being passes in is not, throw an ArgumentException. Without this change the call to mono_object_handle_pin_unbox will assert and kill the process. This can occur when de-serializing an object and the field types have changed. Co-authored-by: bholmes <bholmes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#64214, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
When the field is byref but the value being passes in is not, throw an
ArgumentException. Without this change the call to
mono_object_handle_pin_unbox will assert and kill the process.
This can occur when de-serializing an object and the field types have
changed.