8000 Do not wrap save action with transaction by johnnyshields · Pull Request #70 · mongoid/mongoid_orderable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not wrap save action with transaction #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 27, 2021
Merged

Do not wrap save action with transaction #70

merged 7 commits into from
Jan 27, 2021

Conversation

johnnyshields
Copy link
Member
@johnnyshields johnnyshields commented Jan 26, 2021 •
edited
Loading
  • Fix: Transactions should not use around callbacks
  • Refactor: Partially reduce code complexity of handler classes
  • Tests: Run all test both with and without transactions

@johnnyshields johnnyshields merged commit 2f445c7 into mongoid:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnnyshields
0