8000 fix: match signature of pymongo's collation by minemidnight · Pull Request #895 · mongomock/mongomock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: match signature of pymongo's collation #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix: match signature of pymongo's collation #895

wants to merge 6 commits into from

Conversation

minemidnight
8000 Copy link

mdomke
mdomke requested changes Aug 3, 2024
View reviewed changes
@minemidnight minemidnight requested a review from mdomke August 4, 2024 00:00
@mdomke
Copy link
Member
mdomke commented Sep 11, 2024

I know, it's super annoying but the Type Hinting for Generics in Standard Collections has only been introduced in Python 3.9 and since we have to support Python 3.8 for a month or so. Until then, you would have to use typing.Mapping in the type annotations you added. That's why you're getting the

TypeError: 'ABCMeta' object is not subscriptable

error.

@mbyrne00
Copy link

Hey @mdomke - given it's been over 2 months since your last comment to wait "a month or so", are we ready to proceed with type hints or does this lib still need to continue supporting python 3.8?

@mdomke
Copy link
Member
mdomke commented Nov 22, 2024

@mbyrne00 Python 3.8 has transitioned into EOL-state at the end of October 2024 and I removed support for it recently in #908. I somehow didn't see that @minemidnight adapted the pull-request in the meantime to use Union and Mapping for backwards-compatible type annotations. Nevertheless, I would like the pipeline to succeed, before I merge the pull-request. In #909 I reformatted the codebase with ruff, so that the easiest approach would be to merge develop into this topic-branch and run hatch fmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdomke mdomke Awaiting requested review from mdomke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minemidnight @mdomke @mbyrne00
0